To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=75399





------- Additional comments from [EMAIL PROTECTED] Mon Apr  2 10:33:44 +0000 
2007 -------
Hi Matthias,

thanks for your comments.

Let me comment on them too.

* The changes outside store module are only to use the advantage of the new
format. Usage of the new format is meant for OOo package internally - thus new
regmerge -i switch. I don't see any problem with it, until some 3rd party code
tries to put gigabytes of data into internal registries, which is unlikely. If
the code needs to be ABI compatible I can modify my changes to add new methods
instead of adding new parameters (with default values)

* about semantically incompatible changes, the maximum name length can be fixed
easily to 256+ characters again (by linking more blocks) 

* I think it might be possible to enlarge the stream length limit as well, but I
don't see any point in doing so. Given that store module is only used for
registry files. The new default block size was optimized for current .rdb files
usage. See doc/store.txt analysis in ooo-build from Michael. Excerpt from it:

Analysis:
types.rdb     98% of files < 2^12 bytes < = 4096 bytes
types.rdb     100% of names < 64 bytes
services.rdb  99% of files < 2^8 bytes < = 256 bytes
services.rdb  99% of names < 64 bytes

Largest file == 2^15 bytes == 32k.

I would be quite disappointed if you throw my patch away as I spent some time
with it as you might see ;-)

Please let me know if you are willing accept my patch if I modify it to be ABI
compatible and remove name max length. I might look into maximal stream length
as well if you insist :)

Radek

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to