To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=76159





------- Additional comments from [EMAIL PROTECTED] Wed Apr 11 11:48:57 +0000 
2007 -------
1  Can we get this sorted out definitively?  What platform behaves in what way?

1.0  Standard platforms have _SC_GETPW_R_SIZE_MAX defined in unistd.h, and
sysconf(_SC_GETPW_R_SIZE_MAX) either (a) returns a non-negative value or (b)
returns -1 and leaves errno unchanged.  Does any FreeBSD or OS X version fall in
this category?

1.1  Allegedly, some platforms do not have _SC_GETPW_R_SIZE_MAX defined at all
in unistd.h (and so the question of what sysconf(_SC_GETPW_R_SIZE_MAX) does on
those platforms would be moot).  Old FreeBSD and OS X fall in this category,
right?  (Is Panther older than Tiger?)

1.2  Allegedly, some platforms have _SC_GETPW_R_SIZE_MAX defined in unistd.h,
but sysconf(_SC_GETPW_R_SIZE_MAX) returns -1 and sets errno=EINVAL.  Is that
really true?  Does any FreeBSD or OS X version fall in this category?

2  In your little program
http://eric.bachard.free.fr/mac/i76159/sysconfreturn.c, you should add an
explicit "errno=0;" before the call to sysconf, just to be safe.

3  In i76159_new_Implsec_macosx2.diff,

  +enum Result { KNOWN=0, UNKNOWN=1, ERROR=2 };
  +typedef short Result;

is bad and should really be

  +enum Result { KNOWN, UNKNOWN, ERROR };

For one, why repeat the implicit numeric values, when the exact values are
irrelevant here, anyway?  For another, why hide the enum type with a typedef? 
What is missing for valid C however (I did not test the code I wrote) is to 
change

  +static Result sysconf_SC_GETPW_R_SIZE_MAX(size_t * value) {

to

  +static enum Result sysconf_SC_GETPW_R_SIZE_MAX(size_t * value) {

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to