To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=4695
------- Additional comments from [EMAIL PROTECTED] Wed Apr 18 16:15:41 +0000
2007 -------
Thanks for your answer Eike. Here is mine :
>- Relative reference parts need a special handling, and to be Excel
> compatible [...]
Can you please explain to me what exactly is a relative reference ? My patch
works well on samples documents.
>Btw, interpreter functions should never simply return without having set
>an error value and/or pushed a result. The reason I mention this is the
>line
>+ if (rData == NULL) return;
Ok. I didn't really know what error should be returned. It was more for escaping
segv than anything else. It's not supposed to be an error in first place. But
you're right.
>of your patch. Btw2, in our naming conventions rData should be named
>pData instead, since it is a pointer. If a premature return is needed,
>the code instead should be something like
if (pData == NULL)
{
SetError(errUnknownState);
PushInt(0);
return;
}
Heck, 3 lines for return, you're hard with me, I don't like code too long :).
I will do the change to pData and for premature return in a patch. My CWS is not
here, but it's coming nicely and surely, thanks Sophie ^_^.
Regards,
Michel
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
