To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=56566
User er changed the following:
What |Old value |New value
================================================================================
OS/Version|Windows 2000 |All
--------------------------------------------------------------------------------
Platform|PC |All
--------------------------------------------------------------------------------
Subcomponent|formatting |editing
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Mon Apr 23 17:39:31 +0000
2007 -------
Hi Michel,
Thanks for the patch (it somehow didn't directly apply to m210, probably
because you work on an older milestone and CWS calcwarnings was
integrated in the meantime, but that was easily solved), here some
comments.
If the ScMatValType is SC_MATVAL_VALUE the double value may in fact
encode an error code instead, so before the final result is used the
general treatment should be to check with ScMatrixValue::GetError()
first. Currently any error is displayed as '1.#NAN'. As the previous
simple range approach copied the result string I suggest to use
ScGlobal::GetErrorString() in case the error value is not 0.
As the formula cell is just temporary and not stored, it doesn't need to
be new'ed and can be created on the stack using an automatic variable.
Done.
The ScCompiler instance is not needed, the ScFormulaCell ctor already
compiles the formula string passed. I removed that.
Since SetDataFromFormula now handles things differently, ScRange aSource
isn't needed anymore and certain variables like pTokArr are only used in
the else path and declaration/definition can be moved there. I did that.
Please follow our guidelines and use an indent of 4 spaces. I also
changed the placement of curly braces of the function body and in
if/else/for/... to follow the style we use.
I'll attach the corrected patch, please use it as the basis for further
development, and if possible update your OOo work environment to m210 or
later so we can interchange patches that directly apply.
Thanks
Eike
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
