To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=77023
------- Additional comments from [EMAIL PROTECTED] Fri May 18 19:30:03 +0000 2007 ------- I have attached a patch fixing a crash related to neon-0.26, for example see: http://bugs.debian.org/406926 http://bugs.debian.org/396094 http://bugs.debian.org/401286 http://bugs.debian.org/410917 https://bugzilla.novell.com/show_bug.cgi?id=256652 The function ne_uri_parse has more strict checks for the given URL in neon-0.26.x, so the URLs with non ascii characters are no longer accepted. It seems to be valid, see https://bugzilla.novell.com/show_bug.cgi?id=256652#c9 OOo crashes because there is thrown an exception when the URL is not accepted: --- cut ucb/source/ucp/webdav/NeonUri.cxx --- if ( ne_uri_parse( theInputUri.getStr(), &theUri ) != 0 ) { ne_uri_free( &theUri ); throw DAVException( DAVException::DAV_INVALID_ARG ); } --- cut ucb/source/ucp/webdav/NeonUri.cxx --- My fix is simple. The URL is escaped before it is passed to ne_uri_parse. It fixes the crash. The URL seems to be saved to the file in the same format as with the non-patched OOo and old neon. I hope that it does not break anything. I saw that the string from class NeonUri is unescaped when needed. The most sensitive might be function NeonSession_NeonAuth in ucb/source/ucp/webdav/NeonSession.cxx. It reads username and password from class NeonUri. I am not sure how to test it. I think that it must work because the WebDAW autentification must support escaped strings if they are passed by URLs. Though, I do not know much about WebDAV... What do you think? --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
