To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=73550
------- Additional comments from [EMAIL PROTECTED] Thu May 24 13:05:07 +0000 2007 ------- Michael, the problem is not that you introduced a regression bug - this is common in software development ;-) And yes the #ifdef WNT is also not a very good design approached, but now it's getting really bad. Previously platform dependent code was implemented in a separate platform dependent file and there where ifdefs in the platform independent code to separate the calls to the platform only methods. This was consistent. Now there are several different approaches mixed. The above described plus member function pointers + ifdefs in platform independent code not just for a simple call but for implemented code + implementing a method for a one platform in a platform dependent file and for the other platform in the platform independent file. This is inconsistency at it's best. And this stuff with the m_pInitSystray members...this is simulating C++ inheritance with C code within the implementation of a C++ class. But anyway, if it works regardless whether the design is nice or not - O.K. fine !!! But you actually changed platform dependent Win32 code (SetAutostart was Win32 only before) without understanding how it works. Would have been better to Implement ShutdownIcon::SetAutostart for Unix and place it in shutdownunx.cxx and leave the w32 stuff untouched. Anyway - the really bad thing is that review and QA was only done for Unix along with changing Windows code. That is not acceptable when integrating into the master - period. What I mean with "doing the DeInitSystray and Initsystray in SetAutostart() only for Unix seems to work" is that this patch won't affect the functionality on Unix and rebuilds the previous program logic for Windows along with the several bugs I'm aware of are gone. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
