To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77648





------- Additional comments from [EMAIL PROTECTED] Tue May 29 09:27:05 +0000 
2007 -------
Sorry, if I've been unclear. I wrote this issue because the "Undo" does not work
correctly. The action itself (changing number format from 'text' to 'date')
works as expected.
What I mean:
If you change the number format of a cell, two things should happen:
1. the number format of the cell changes (regardless of the content of the cell)
2. if the cell contains one single paragraph, this text will be reinterpreted
for the new number format, but if there is more than one paragraph in the cell,
the text should _not_ be reinterpreted.

Undo should change back the text if step 2. has been performed and of course,
step 1.
The problem is that Undo actually works only if step 1. _and_ step 2. has been
performed. If the condition of step 2. has not been fulfilled, neither step 2.
(which is okay) nor step 1. (that's the bug) will be undone.

Your patch would change the behavior in a way that step 1. and step 2. will be
performed regardless of the content of the cell. This would of course solve the
undo-problem but it would change the wanted behavior.
For this issue you should not change IsValidNumTxtNd(..) or their calling
functions in a way that step 2. will performed even there is more than one
paragraph. 
You should instead try to record the change of step 1 even when step 2. is
skipped. This does not work at the moment and is the reason for the failing of 
undo.

For issue 77649 we have to fix IsValidNumTxtNd(..) itself, I will provide some
comments into the other issue as well.


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to