To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77687


User mmeeks changed the following:

                What    |Old value                 |New value
================================================================================
                      CC|'cmc'                     |'cmc,kr'
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Wed May 30 14:22:20 +0000 
2007 -------
This looks like a duplicate of 76245: caused by the overlap of 2 CWS' one making
the empty string const, and salstrintern adding interning :-)

Your fix looks fine: though 2 things prolly would improve it:

if (SAL_STRING_IS_STATIC_FLAG (str)) instead of is_already_intern :-)

And 2ndly, a regression test so we don't screw it up again ;-)

sal/qa/rtl/oustring/rtl_OUString2.cxx (intern)

would rock - run with 'testshl2'

I wonder if we can encourage Kay to do some code-review style QA :-)

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to