To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77649


User ama changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |STARTED
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Fri Jun  1 15:24:50 +0000 
2007 -------
Yes, your last patch will work for every scenario I'm able to imagine :-)
Now  we can have a look if it can be optimized. Your new code iterates the cell
content, the SwNodes::GoNexct(..) function call iterates the cell content, too.
Your iteration is necessary but the old GoNext(..) call can be removed if your
iteration delivers the correct text node.
Something like this:
SwTxtNode *pTextNode = 0;
for(..pNext..)
{
  if( IsTableNode() )
  {
    pTextNode = 0;
    break;  // Table found
  }
  if( IsTxtNode() )
  {
     if( pTextNode )
     {
        pTextNode = 0;
        break;
     }
     pTextNode = pNext;
  }
}
if( pTextNode )
{
    .....
}
else
  return ULONG_MAX;

What do you think?

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to