To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=63500





------- Additional comments from [EMAIL PROTECTED] Fri Jun  1 17:47:51 +0000 
2007 -------
Hi Niklas,

> The change has to be in ScStringCell constructor, not SetString. SetString
> is used only in CorrectSymbolCells and should be removed one day.

that would explain why I saw no win then ;-)

> UniString::intern had one "&" too many, apparently it's never been used.

yep - though, clearly I thought I was testing it ;-)

> If all strings really are different, of course this adds some overhead

sure, particularly because the stl hash is somewhat inefficient; we can prolly
reduce the cost to ~8bytes per string with a custom C impl. there.

> This roughly offsets the hash time, so we don't get slower overall.

Neat, you rock :-)

> For large documents, the reduced memory usage will often improve

Hopefully for pivot tables it'll have a large effect; quite possibly we want to
do more string comparisons there using some 'check-pointers-first' variant of an
equality check.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to