To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=77996
------- Additional comments from [EMAIL PROTECTED] Fri Jun 8 14:56:05 +0000 2007 ------- Yes, fallback is good I think, and init is also cleaner. However, the OpCode isn't part of the data anymore and by having declared the default parameter in addToMap() it isn't noticed. Btw, for type safety that should be ocNone instead of SC_OPCODE_NONE. The SC_OPCODE_... defines are only needed/used for the resource and are assigned to OpCode values in sc/inc/opcode.hxx and not used elsewhere. For simplicity I'd add the OpCode to the TransItem array. The call to ScCellKeywordTranslator::transKeyword() then should include ScGlobal::pSysLocale and the calling function's OpCode. Are the French translations really simple ASCII strings in Excel? No letters with accents? If there were non-ASCII characters involved the thing wouldn't work.. maFR doesn't need to be a member variable of ScCellKeywordTranslator, it can be constructed temporarily in ScCellKeywordTranslator::init(). Btw, a word on coding style: for references to objects we use the 'r' prefix, so for parameters it would be rKey instead of aKey, rName instead of aName, rLocale/aLocale, ... --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
