To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=47724
User er changed the following:
What |Old value |New value
================================================================================
CC|'jodygoldberg,joergwartenb|'er,jodygoldberg,joergwart
|erg,mmeeks,st' |enberg,mmeeks,st'
--------------------------------------------------------------------------------
Assigned to|er |muthusuba
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Mon Jun 11 13:52:20 +0000
2007 -------
I absolutely don't like the approach of scattering the interpreter with hundreds
of if(x==0.0){SetError(errDivisionByZero);}else{z=y/x;}
This should be a static ScInterpreter member inline function instead that codes
the error into the return value and then let PushDouble() and similar handle the
coded error if necessary, as usual. Such as
static inline double ScInterpreter::div( double a, double b )
{
if (b == 0.0)
return CreateDoubleError( errDivisionByZero);
return a / b;
}
This then simply can be used in z=div(y,x); statements without having to worry
about anything.
Muthu, please rework the patch and reassign this issue to me when done.
Thanks
Eike
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
