To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=78495
------- Additional comments from [EMAIL PROTECTED] Fri Jun 15 20:03:44 +0000 2007 ------- Hi Matthias, glad it's slightly useful; and yes, it's a patch for discussion, not per-se merging as is :-) [ I know you're working on this ]. > Yes, indeed we're doing CRCs on every Page(header) read from disk. And this > is still regarded as useful, in that we can detect inconsistencies, and > report them (in that a read may fail with "store_E_InvalidChecksum"). Is the read itself failing actually useful though ? does the calling code handle this, and can anything meaningful (or even useful) be done in this error case ? [ does this code path even get tested at all ]. I can believe for the SuperBlock case (where apparently we can use another block) it -might- be somewhat useful but ... AFAICS these registry files are written once, and subsequently ~not at all for the lifetime of the install. Or, at least they are written extremely infrequently and read very frequently. Consequently -if- it is at all necessary to have some integrity check, can it not be some crawl of the structures post create; rather than on every read ? It seems we have fewer checks (CRC wise) on our valuable document data ;-) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
