To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=18907
User fs changed the following:
What |Old value |New value
================================================================================
CC|'' |'fs'
--------------------------------------------------------------------------------
Assigned to|fs |dyf
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Thu Jun 21 12:28:24 +0000
2007 -------
fs->dyf: better, but not yet finished:
- With a recent version, this does not compile on some platforms because
OTableCopyHelper::pasteTable (the version in TableCopyHelper.cxx:507)
does have a (new) parameter _sTableName, which it does not use. For some
compilers, this is a warning, and warnings are reported as errors in
a regular OOo build.
- Now we have the desired behaviour when we paste, for instance, a Calc
cell range into a Base document. In this case, the table which is selected
in Base is used as default table name - fine.
However, now we have an inconsistency: When you copy a Base table itself
to the clipboard, and then paste it, then the current selection in the
application is *not* respected.
We should fix this case, too, for consistency reasons.
- in DExport.cxx:781, you change the default from WIZARD_DEF_DATA to
WIZARD_APPEND_DATA. That's not completely what I meant with my comment:
Now the default is *always* to append, even if the suggested table name
does not yet exist. For instance, select *no* table in Base, and then
paste => you will get a dialog which has "Append" pre-selected, but
a non-existent table name. That's not what we want to have here.
I suggest you completely remove the last parameter of the OCopyTable
constructor, and make a reasonable guess inside the constructor: If
the a table with the given name already exists, then pre-select "Append",
else pre-select "Create".
(Alternatively, you can spare this piece of the patch, since it's not
part of the original bug.)
Thanks.
(side note: If possible, please next time generate one big file containing the
changes for all files, this makes applying and reviewing on my side much easier.
diff -ru should do. Thanks.)
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
