To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78747





------- Additional comments from [EMAIL PROTECTED] Fri Jun 22 19:22:24 +0000 
2007 -------
integration tests for form controls are located in forms/qa/integration/forms.
Just do a dmake, followed by dmake run. You'll need a running office started
with the usual "accept=" parameter, though. This will run a couple of tests ...

However, no of those tests involves clicking buttons, though ListSelection could
be easily extended to do so.

In general, the changes you did shouldn't affect form controls, as far as I can
see. However, QA should be told to run the forms auto tests on the CWS where
this will be checked in.

Yet more on general notes: I'd prefer (but that's my personal opinion only)
fixing the button classes, to always call the PushButton::Click, for the sake of
consistency. Something like
  ImplDelData aDelData;
  ImplAddDel( &aDelData );
  PushButton::Click();
  if ( aDelData.IsDelete() )
    // button has been deleted in the handler
    return;
  // close the parent window, as before when no handler were set
  ...

IMO, this would be a cleaner solution. Might be worth asking PL for potential
side effects (there shouldn't be any, as far as i can judge).

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to