To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=78291
------- Additional comments from [EMAIL PROTECTED] Mon Jun 25 08:28:28 +0000 2007 ------- fs->mmeeks: architecture-wise, the patch looks okay to me. I especially like the fact :) you did not introduce redundancies in the property lists, but implemented the model property list by using the peer's property list. If it were me to review the patch otherwise, I'd insist on you replacing the fprintfs with OSL_TRACE calls. There ain't no places in the OOo code where we explicitly printf, instead, OSL_TRACE is the choice for console traces. We shouldn't silently change this habit. In particular, release versions of OOo are not expect to trace to the console, so the unconditional printfs should definitely be removed, IMO. For the combo box not being derived from the edit: well this makes sense. Partially, at least. For one, it's consistent with the respective models. And for the models, the approach was probably chosen because a combo box facilitates a specialized edit, but isn't really one itself. Some of the properties which you cite show this - multi line edits don't make much sense for a combo box. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
