To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=79097 Issue #|79097 Summary|overrun with maxvalue in odbc OTools::getStringValue f |or unicode varients Component|Database access Version|OOo 2.2.1 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|none Assigned to|fs Reported by|cmc
------- Additional comments from [EMAIL PROTECTED] Mon Jul 2 15:08:26 +0000 2007 ------- in OTools::getStringValue we have sal_Unicode waCharArray[2048]; and sal_Int32 nMaxLen = sizeof(waCharArray) - sizeof(sal_Unicode); so nMaxLen is now "4094" later on we have the case of... nLen = pcbValue != SQL_NO_TOTAL ? std::min(pcbValue, nMaxLen) : (nMaxLen-1); i.e. nLen could now be 4093, and so waCharArray[nLen] = 0; would be totally busted. So I've attached a patch, but I'll leave patch unset as I'm unsure as to what units the various methods work in. i.e. which ones (if any) work in number of characters vs some working in number of bytes --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
