To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78747





------- Additional comments from [EMAIL PROTECTED] Fri Jul 13 19:48:06 +0000 
2007 -------
> Wow - it seems everyone is obsessed by printf's :-)

Well - if you submit a patch, don't pollute it with things which do not belong
into it - or mention it's not for checkin in this form. IMO.


For disabling the default behaviour: probably makes sense to allow for it. Is it
feasible to evaluate the return value of the click handler for this?

In general, I agree to Malte that the chosen way is debatable, at least. It
introduces additional complexity in how toolkit and awt interact, and reading
things like "When you create a dialog via the toolkit, the closer won't close
the dialog automatically." makes me think we already have way too much of this
complexity.

So, if we'd have infinite time :), I'd vote for
- always fire the events in VCL (not firing them if there's a handler is
  nonsense)
- always call the click handler
- in both cases, evaluate a return value whether or not processing should
  continue
- finally do the default handling for the special buttons.

Something like this.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to