To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=59025
------- Additional comments from [EMAIL PROTECTED] Mon Jul 16 13:16:03 +0000 2007 ------- Yes, your patch solves this issue for the most use cases and could be integrated without changes. But I've some ideas how you could make it even better. 1. I said "most" use cases. But if you create more than one view to your document (Window/New_window) your patch will work for one view only. This is a little nitpicking, because this is not very usual and actually your patch improves the situation even for two views. 2. One important goal for me is to make our code more maintainable. So I'm trying to reduce the dependencies bewtween different parts of our code. From that point of view I would prefer not to use (and the new include of) the SwCrsrShell in undo code. How can we stay with your idea (remember the cursor position at the undo object and use this if needed) and solve 1. and 2.? What about the use of a node index (or a pair node index/content index) instead of the document coordinates? In SwDoc::_MakeFlySelection(..) there is a parameter rAnchPos which can be used. You could remember the node index of this parameter in undo (only the index, not the node itself). This index can become a new optional parameter for SwUndo::RemoveIdxFromSection(..) and can be used to construct the aPos object. This should work for all views. What do you think? --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
