To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=26795
------- Additional comments from [EMAIL PROTECTED] Wed Jul 25 21:46:57 +0000
2007 -------
Hi weiz. Thanks, the patch is almost fine :-). But there are some points to
improve still:
- SCHATTR_END must be set to the new define SCHATTR_GROUP_BARS_PER_AXIS
- the changes in BarChart.cxx are too complicated, try to change only the method
BarChart::addSeries by replacing the comment "////if( bars side by side ) zSlot
= 0; //@todo uncomment this later on dependent on new flag" with:
if( !pSeries->getGroupBars() )
zSlot = 0;
-in the method ChartTypeHelper::isSupportingGroupBars()
it would be more save to check eStackMode != StackMode_NONE
-The default for GroupBarsPerAxis is true. GroupBarsPerAxis == true should
represent the behavior that we had without this feature: The bars were grouped
per y-axes.
- So the method should better be named
ChartTypeHelper::isSupportingNotToGroupBarsPerAxis()
- I think it would be better to not shorten 'GroupBarsPerAxis' to 'GroupBars' as
the latter can be misinterpreted more easily
- consider to not offer the setting when all series are attached to the same
axis, because there is no visible effect then
- finally it's easier to compile when you add the new token at the end of the
token list in xmloff. Otherwise consider to use an alphabetical place and make
an incompatible build from xmloff.
Hope I haven't overseen anything.
Looking forward to the next version :-)
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
