To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=20496
------- Additional comments from [EMAIL PROTECTED] Tue Aug 21 13:51:27 +0000 2007 ------- TBE->MUTHUSUBA: I had a look at your patches sc-startformulawplus-updated.diff and sc-formula-input2.diff and found a few problems: - In ScViewFunc::EnterData() the exceptions as specified in rule 4 of section 1.1 in the specification (http://specs.openoffice.org/calc/ease-of-use/Enhanced_Formula_Input.odt) are not converted to text but to a formula, e.g. '++1', '+-+1', '+', '-', '++', '--', etc. In addition invalid non-auto-corrected formulas are converted to a formula instead of a text. - In ScTabViewShell::ExecuteInputDirect() you make use of ScFormulaCell for checking if reference input should be active. One problem I found is that there are several cases, where your comparison with the error codes failes and reference input mode is not active, e.g. when you enter '+max('. In this case you get an error errIllegalArgument. In general I think the algorithm relying on error codes as errUnknownToken is rather fragile. Another problem with the usage of ScFormulaCell is performance. For complex formulas one runs into serious performance problems, because the formula is interpreted before switching to reference input mode. Nevertheless thanks for your patch. I hope you don't mind that I fixed the remaining issues in CWS calcformula. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
