To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=77446
------- Additional comments from [EMAIL PROTECTED] Fri Sep 7 12:42:08 +0000 2007 ------- Hi! I'm terribly sorry about the long delays... I have reviewed all of these patches now, and I think they are alright. The mistake that Oliver noticed was that in one instance I changed the order of declaration of attributes in the hxx file to match the order the attributes were initialized in the constructor in the cxx file. The problem with this is that no matter the order they are listed in the contructor the attributes are initialized in the order of declaration so this way I changed the tab order of some GUI elements accidentally. There are more examples of changing the order of declaration in the patches, but after reviewing them I think they are for the better. From looking at the constructors it clearly looks like the programmer intended those attributes to be initialized in an order different from the declaration, because they are depending on each other. These changes also do not happen in GUI classes, so hopefully they do not change anything for the worse. The diff still contain a number of instances where it seems that I just accidentally added some newlines or other formatting, sorry about that. Also there are a number of changes that concern the sal_Int32 vs long literal problem, which I still don't clearly understand and on which I was trying in vain to get feedback from the guys who wrote the code checking application. I think it's safe to omit these patches for now. The rest of the changes are more diverse and I think they are okay. Thank you for your patience! --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
