To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=81252





------- Additional comments from [EMAIL PROTECTED] Mon Sep 10 08:49:30 +0000 
2007 -------
I added your patch into the latest source and gave it a whirl. It does indeed
fix the original testcase that I posted, but testing it some more I've managed
to make it crash :-(

Try the following makefile:

HELLO = "C:\Temp\directory with spaces\hello.exe" "arg"

all :
        @echo $(HELLO)
        @$(HELLO)

where the hello.exe program is as before, just moved into a sub-directory. When
I place that makefile in C:\Temp and run "dmake" I get the expected output:

"C:\Temp\directory with spaces\hello.exe" "arg"
Hello, world.

followed by a crash. Rebuilding in debug mode and firing up the debugger, I find
that the crash happens here:

NTDLL! 7c910f29()
NTDLL! 7c910d5c()
DMAKE! free + 102 bytes
Exec_commands(tcell * 0x0032be70) line 1380 + 9 bytes
Make(tcell * 0x0032be70, tcell * 0x00000000) line 750 + 9 bytes
Make(tcell * 0x00322400, tcell * 0x00000000) line 580 + 13 bytes
Make(tcell * 0x00322360, tcell * 0x00000000) line 580 + 13 bytes
Make_targets() line 241 + 14 bytes
main(int 0, char * * 0x00320f90) line 441 + 5 bytes
DMAKE! mainCRTStartup + 180 bytes
KERNEL32! 7c816fd7()

The value of "cmnd" that is being passed to FREE() by Exec_commands() looks
corrupted: "C:\TempJ [sic!] followed by bytes 0x01, 0x09, 0x00.

Trying the same makefile with the unpatched sources, of course, gives an error,
but if I change the makefile to what the patch would effectively do to it, 
namely:

HELLO = "C:\Temp\directory with spaces\hello.exe" "arg"

all :
        @echo "$(HELLO)"
        @"$(HELLO)"

then it runs OK without crashing.


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to