To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=1163
User iha changed the following:
What |Old value |New value
================================================================================
CC|'billjoie,iha,kamataki,mmp|'billjoie,iha,kamataki,mmp
|,pagalmes,tonygalmiche,vio|,pagalmes,tonygalmiche,vio
|n' |n,weiz'
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Tue Oct 16 06:56:17 +0000
2007 -------
Thanks for the patch and the specification. There are still a couple of issues
to solve.
1) Regarding the UI strings: In the menu we already use 'Secondary X Axis' so I
think the according title should be called 'Secondary X Axis Title'. You have
done this in the string STR_OBJECT_TITLE_SECONDARY_X_AXIS, but the menu and the
title dialog is inconsistent. At least the menu should be changed to become
consistent. Hm, with the title dialog there will probably be a space/layout
problem, when using the lengthy wording 'secondary'. I would suggest to use a
heading 'Secondary axes title' for the both additional edit fields and then skip
'2nd'. I will ask MMP for input on this but he is on vacation this week.
2) The patch has a compilation conflict with a more up to date master (231) with
the ResourceIds. You can avoid this by using the IDs 87 and 88 for
STR_OBJECT_TITLE_SECONDARY_X_AXIS and STR_OBJECT_TITLE_SECONDARY_Y_AXIS.
3) The patch has a conflict during applying it on a more up to date master
because one of the changed files was renamed:
chart2/source/controller/dialogs/res_Titles.src is renamed to
res_Titlesx_tmpl.hrc
4) We will get duplicate used HelpIds for HID_SCH_TITLE_SECONDARY_X and
HID_SCH_TITLE_SECONDARY_Y when CWS chart14 gets integrated. This needs to be
checked manually again before commiting.
5) Regarding the title dialog specification: For the new controls it says
'Enabled, If the current chart supports a secondary x axis' .But I think the
implementation is like: 'Enabled, if the current chart has a secondary x axis'.
This inconsistency should be resolved.
6) Formatting issue: All the date formats in the specifiction documents are
corrupted somehow. Please keep in mind that the documents are english.
7) Pixel issue: The space at the bottom of the title dialog is to small.
8) Variable naming issue: The new parameter 'bShow' at the title resources
should state more precisely what it is supposed to influence. Please call it
bShowSecondaryAxisTitles or similar.
...more next time
But you are on the right way!
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
