To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=31097
------- Additional comments from [EMAIL PROTECTED] Wed Oct 17 17:37:44 +0000 2007 ------- Hi maoyg, That looks better. But there are still scenarios which are problematic with the new behavior: 1) When a user starts to choose a symbol from file and aborts the dialog with cancel then the size is set to zero (this should be avoided). It is wrong to change anything in that case I think. So return from the method when you get no graphic there. 2) If an image from gallery or file was set before with a size with an aspect ratio different from 1:1 and the user now switches to standard symbol, the standard symbol looks broken as the aspect ratio does not fit. I think we need this additional logic: If the user switches from gallery or image to standard symbol and the aspect ratio is different from 1:1 then the size must be adapted still. Please reset the size in those cases to a mean value of width and heigh. 2b) If we need this complex logic for the standard symbols anyhow, I think we should use it for the automatic symbol also. The old code line "aSymbolSize=aAutoSymbolGraphic.GetPrefSize();" ignores the variable bResetSize badly anyhow. So I would suggest to remove it. Please have an eye on the variable 'bNewSize' here also. For me it looks wrong that it is set to false. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
