To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=76247


User fme changed the following:

                What    |Old value                 |New value
================================================================================
             Assigned to|fme                       |pflin
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Mon Oct 22 12:44:51 +0000 
2007 -------
fme->pflin: I'll take over again. I'm sorry that you had to wait that long. 

>From my point of view there are still some issues remaining:

1. According to the OASIS specification, the string has to be named
layout-grid-standard-mode, not layout-grid-square-mode, please check this.

2. I think we should not write style:default-page-layout in case that the grid
mode is set to standard. This way we avoid ODF 1.1 validation errors if the new
feature is not used. Please find a patch attached to this issue for this.

3. According to the specification, layout-grid-standard-mode should be ignored
if it is located inside a <style:page-layout> attribute. Therefore I think we
should not write layout-grid-standard-mode inside the <style:page-layout>
attribute as your code currently does.

4. Writer has been made warning-free since SRC680m231. Please resync to a newer
milestone and check if there are any compiler warnings.

5. I still opt for having the grid mode checkbox in the Asian settings dialog,
even if this is a Writer only setting. This is definitely the best place for any
Asian specific settings.

6. When opening the text grid page for the first time, I always get an
assertion, that standard.soc could not be loaded correctly. Looks like the
'office' namespace could not be found by GetKeyByAttrName in xmloff. Do you
observe the same?

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to