To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=59025
------- Additional comments from [EMAIL PROTECTED] Thu Oct 25 09:42:12 +0000 2007 ------- ama->liuyu: I have two remarks to your patch. 1. For the construction of the SwUndoInsLayFmt you get the new needed ULONGs from two different members?! The SwNodeIndex-ULONG you get from rAnchPos but the SwIndex-ULONG you get from GetEditShell->GetCrsr().. You better use rAnchPos for the SwIndex-ULONG as well. Even at that moment GetEditShell()->GetCrsr()->GetPoint() seems to be identical to rAnchPos, it makes the code more at least more readable. 2. When you create a SwPosition again from those two ULONGs, you need a SwNode and a SwIndex again. How you get the SwNode is oikay, but you should not create a SwIndexReg on the heap and use this for SwIndex. (BTW: this is a memory leak because this object will never be destroyed). If a SwPosition is created with a SwNode and a SwIndex, there is a "must": if the SwNode is a SwTxtNode, the SwIndex has to be registered in this SwTxtNode. (Remember: a SwTxtNode is a SwIndexReg). Please have look at my attachment (id=48547) from Sep 27 and at our Writer Wiki http://wiki.services.openoffice.org/wiki/Writer_Core_And_Layout#Indexes_and_Positions --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
