To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=44830
------- Additional comments from [EMAIL PROTECTED] Mon Mar 14 09:38:32 -0800 2005 ------- This is quite a nasty problem. 1. The crash as described above occurs too when the context menus of the master page controls are used to assign master pages to the document. The context menu are the big problem here. 2. In order to show a context menu we need a view shell. This view shell has to be high enough on the SFX shell stack so that it overrides other shells that handle the same slots. 3. The SFX shell stack is a stack. So when we just rearrange the order of the three view shells asociated with the three master page controls we have to take all shells above those three from the stack, rearrange the three master page view shells, and put the other shells back on the stack. 4. To be on the save side the three master page view shells are not only rearranged but are moved to the top of the whole SFX shell stack as well. 5. All this takes place while the edit mode is active and the undo manager is bound to the top most shell: The association between undo manager and view shell is broken. When the edit mode is finally ended the wrong undo manager is restored. Crash. There are two solutions (that I can think of) for this problem: 1. Leave the edit mode when a master page is assigned to slides in the document. The poblem with this is that the edit mode has to be ended before the context menu is displayed. Even when the user does not select any of its entries. 2. Do not modify the shell stack. For this we have to do two things: a) do not move the view shells of the master page controls to the top of the shell stack; make sure that the slots of the context menus are not used by any other view shell possibly on the stack. b) Replace the three view shells by one that forwards the slot calls to the correct master page control. At the moment I favor the second solution. It does not alter the behaviour (ending the edit mode) as much as the first solution. It does, however, need more changes to the code with more chances of new errors. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
