To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=79739
User bm changed the following:
What |Old value |New value
================================================================================
CC|'fs' |'fs,mmp'
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Tue Oct 30 13:20:32 +0000
2007 -------
->weiz: Thanks for the patch. First, there are two warnings. As warnings are now
treated as errors, please remove them. One of the warnings is in fact an error:
BOOL DataEditor::Close()
{
if( ApplyChangesToModel() )
return ModalDialog::Close();
}
Nothing is returned if the call to ApplyChangesToModel() returns FALSE. What
should be returned then, I suppose TRUE?
The other warning can be fixed by adding
using BrowseBox::MouseButtonDown;
in DataBrowser.hxx in the class declaration.
The behavior is still not like expected. What works and is good:
* enter "-", the buttons are disabled, but you can continue typing
* click somewhere else in the table -> message box
What does not work like expected:
* Enter "x", press Tab, nothing happens. Correct: open the warning dialog
* Enter "x", click into a series header, nothing happens, Correct: open the
warning dialog
* Enter "x", click into another cell -> the warning comes up. Sometimes (haven't
found out when exactly) the string is not visible but the former number, and no
cell is active. Clicking into the cell does not activate it but bring up the
dialog again.
What I also mentioned: when you entered an invalid entry in a cell, you can not
close the dialog until you have entered a number in that cell again. My
suggestion would be instead of the button "OK", offer two buttons: "OK",
"Cancel" or "Correct", "Ignore", or "Continue", "Abort". Where the first button
lets you correct the input, and the second one just ignores the incorrect input
so leaves the old value in the model.
->MMP: What do you think about the suggestion in the last paragraph? Which
button combination would you prefer, in case you like the idea in general?
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
