To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68639
------- Additional comments from [EMAIL PROTECTED] Thu Nov 1 15:13:50 +0000 2007 ------- Thinking a bit about your patch: GetDefaultEncoding() in the way you proposed it should be a private method of the RTFParser. This way to detect an encoding is a special hack for MS file format based Windows tools. So we shouldn't move that code to VCL. The proper default encoding should be what you get from osl_getThreadTextEncoding or osl_getTextEncodingFromLocale. Our hack only is for this special case. And it failed for the same broken tools located on Linux. Besides that I would be more confident if we had a clear explanation for which encoding should be chosen for what encoding. On Windows osl_getTextEncodingFromLocale works fine at least for the "uk","tr" and "ru" locales but I think it should be fine to use the same method for other locales. But I currently don't know what implementation is used on other platforms. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
