To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=82653


User vq changed the following:

                What    |Old value                 |New value
================================================================================
                      CC|'tono'                    |'hjs,tono,vq'
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Sun Nov 11 14:22:46 +0000 
2007 -------
While working on a CWS to remove the need for WRAPCMD I found this in
solenv/bin/modules/installer/servicesfile.pm:

+                    if ($ENV{'USE_SHELL'} eq "bash" ) {
+                        if ($servicesdir =~ /^\w\:/) {
+                            $servicesdir =~ s/\://;
+                               $servicesdir = '/cygdrive/' . $servicesdir;
+                        };
+                                       $servicesdir =~ s/\\/\//g;

Who did the review for this?

First it only checks for bash, what about tcsh? This is bound to break for the
still supported tcsh.

Secondly pasting just /cygdrive/ in front is wrong. Cygwin allows to change
the root path of the drive letters, so instead of assuming it is /cygdrive
one has to use qx{cygpath ...}.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to