To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=73682





------- Additional comments from [EMAIL PROTECTED] Wed Nov 28 16:15:19 +0000 
2007 -------
ama->lijian:
Now it becomes really complicated :-(
I will need more time for analysis, but here my first thoughts:

Our plan was to protect Writer from running into trouble because of a complete
empty document. So you found a fix in docredln.cxx where a rejection/acceptance
of a redline was checked if this would result in an empty Writer element. If
this is detected the patch shrinked the SwPaM of the redline in a way that at
least an empty paragraph will stay.
I still think this is a good idea.
In your last scenario the condition found a problem and manipulated the SwPaM.
Later on you get a crash. With your last patch the condition will not detect a
problem, not manipulate the SwPaM and not crash afterwards.
But what I do not understand is why do we crash? Even if the condition was not
perfect this should result into a superfluous empty paragraph but never into a
crash?!
So I would like to understand the crash before we adjust the condition.
That's my first thought.
My second thought is the condition. Because I want to allow change tracking
inside tables (issue 16398) this check should avoid empty table cells as well.
Your last patch would not detect a problem inside a table cell.



---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to