To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=15456
------- Additional comments from [EMAIL PROTECTED] Mon Dec 3 13:59:23 +0000 2007 ------- As for UTF-8: I think it is not required to export any characters ad entities except those below 128 . I therefore suggest to change line 405 from if( c < 256 || RTL_TEXTENCODING_UTF8 != rContext.m_eDestEnc ) to if( c < 128 || RTL_TEXTENCODING_UTF8 != rContext.m_eDestEnc ) As for ISO_8859_2/Windows 1250: While I do understand that it may be easier to read a document in a text editor if there are no entities, we have to understand that after applying the patch, documents will only loaded correctly into text editors whose encoding is set to ISO 8859-2/Windows 1250. If a document is loaded into an editor that has a different encoding set, characters above 128 may be displayed incorrectly. Using the entities here as it is the case today ensures that documents are editable regardless of of the encoding that is set in the editor. For this reason, I have a slight preference for removing the entities for UTF-8 only. If we anyway want to get rid of the entities for other encodings, too, we may consider to call lcl_svhtml_GetEntityForChar for characters above 128 if any only if the conversion into the destination format failed, that is, in line 458. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
