To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





------- Additional comments from [EMAIL PROTECTED] Thu Jan 17 09:32:59 +0000 
2008 -------
TBE->GAOZM:

================================================================================
FilterOperator2.idl
================================================================================

Please use spaces instead of tabs for indentation.

> module com {  module sun {  module star {  module sheet {

Please add a comment here. It also makes sense to explain, why FilterOperator2
was introduced (additional filter operators).

>
>       constants FilterOperator2

I think you can already use published here.

>       
> //-------------------------------------------------------------------------
>
>      /** selects begins-with entries.
>      */
>        const long BEGINS_WITH = 14;

Please indent as follows:

    /** selects begins-with entries.
     */


================================================================================
TableFilterField2.idl
================================================================================

Please use spaces instead of tabs for indentation.

> module com {  module sun {  module star {  module sheet {

Please add a comment here. It also makes sense to explain the difference to
TableFilterField.

>
> struct TableFilterField2

I think you can already use published here.

>       
> //-------------------------------------------------------------------------
>
>       /** specifies the type of the condition.
>        */
>       long Operator;

Please note in the comment, that type FilterOperator2 is used here.

>       /** selects whether the <member>TableFilterField::NumericValue</member>
>               or the <member>TableFilterField::StringValue</member> is used.
>        */
>       boolean IsNumeric;

Please exchange TableFilterField with TableFilterField2 here.


================================================================================
XSheetFilterDescriptor2.idl
================================================================================

Please use spaces instead of tabs for indentation.

>module com {  module sun {  module star {  module sheet {

Please add a comment here. It also makes sense to explain the difference to
XSheetFilterDescriptor.

>       published interface XSheetFilterDescriptor2: 
> com::sun::star::uno::XInterface

You cannot use getFilterFields() and setFilterFields() as method names here,
because this leads to problems when implementing this interface at the same
C++ object which implements XSheetFilterDescriptor. Also for Basic macros this
gives some problems. Therefore please use other names.


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to