To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=71158
------- Additional comments from [EMAIL PROTECTED] Tue Jan 22 00:26:56 +0000 2008 ------- Hi Lvhue, The patch looks good in general, but all hunks didn't apply. It looks like you created the diff against some already modified file where tab indents were replaced by spaces. Using the patch --ignore-whitespace option helped. Please submit patches only as diff against an original file revision as present in CVS. Thanks. Some detail: approxFloor() should be called before the argument value is checked for <0.0 because precision rounding errors may lead to very small negative values where approxFloor() would still result in 0.0 I didn't compile and test the modification yet in the application. Does it meet all needs as specified in the ODFF draft? Especially the "Given GCD(a;0), a is returned, so GCD(0;0) is 0.", also with more than two arguments? It looks like it does, just want to make sure. Thanks Eike --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
