To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=86643
------- Additional comments from [EMAIL PROTECTED] Wed Mar 5 17:13:19 +0000
2008 -------
Hi Yue,
Almost.. for the case svSingleRef the patch unconditionally casts pCell to
ScFornulaCell* to call pFCell->GetErrCode(). That would be illegal if the cell
wasn't of type ScFormulaCell. Obtain the cell type first using
pCell->GetCellType() and check for CELLTYPE_FORMULA and only if so do the cast
and obtain the error code.
I also would not extract the ifCOUNT case from the switch to introduce another
if(eFunc==ifCOUNT) but handle the formula cell case inside the
switch(eFunc){case ifCOUNT}, decrementing nCount again in case it was a formula
cell with error result. That would save one comparison for all other functions
not being ifCOUNT. Might sound like nitpicking but ... The error case is an
exceptional case, so generally nCount would only be incremented.
For the case svDoubleRef, as now ifCOUNT is handled explicitly in switch(eFunc),
the default case there can be removed, that only handled the then remaining
ifCOUNT case.
Thanks
Eike
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
