To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=86850 Issue #|86850 Summary|replace the mix of XMultiServiceFactory/XComponentCont |ext in OGenericUnoDialog, introduced with CWS rptchart |01 Component|framework Version|current Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|code Assigned to|oj Reported by|fs
------- Additional comments from [EMAIL PROTECTED] Sun Mar 9 20:51:13 +0000 2008 ------- CWS rptchart01 introduced a member "m_xContext" of type XComponentContext, which is filled if and only if the class-ctor taking an XComponentContext is used. If the other ctor (taking an XMultiServiceFactory, which is kind of a legacy version of the XComponentContext) is used, this member is not set. This behaviour is prone to breakage: clients which use the Service-Factory-ctor will be, sooner or later, tempted to use m_xContext. Also, the member is, speaking strictly, superfluous, since it could be obtained from the m_xORB member. For those reasons, the change introduced in CWS rptchart01 should be corrected, in either of two ways: 1. Also initialize m_xContext in the first ctor 2. don't maintain two different members, but only one, and adjust the clients/derivees where necessary. This could be done by either removing one of m_xORB or m_xContext, or by replacing /both/ of them with an instance of ::comphelper::ComponentContext, which provides convenient access to the combined functionality, plus more convenience methods. Do I need to mention I'd prefer the second way? --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
