To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





------- Additional comments from [EMAIL PROTECTED] Wed Mar 26 17:08:05 +0000 
2008 -------
Hi Gao,

I tried to apply your sc(2).patch from Mar 18, 2008, but the patch
fails for sc/source/ui/vba/vbarange.cxx:

Hunk #1 FAILED at 105.
Hunk #2 FAILED at 3324.

It also seems, that the corresponding code in ScVbaRange::AutoFilter() has
changed, please check.

As this part of the patch should only affect VBA specifics, I tested
your patch. If I create a standard filter with the new filter conditions
it seems, that the new conditions are not saved to the xml file.
In addition, I get the assertion "Falscher Filter-enum" from
ScFilterDescriptorBase::getFilterFields() or
ScFilterDescriptorBase::getFilterFields2().
Do you observe the same problem?

Before you submit the next iteration of your patch it would be nice,
if you combine all your sc patches into one patch, because due to
the amount of patches it gets more and more difficult for me to
keep track of all the patches. In addition it would make sense
to refer to the latest DEV300 milestone.

Thomas


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to