To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=87197
------- Additional comments from [EMAIL PROTECTED] Mon Apr 7 19:41:07 +0000 2008 ------- fs->mav: Argh, you're absolutely right ... I missed the point that in fact the previous version of the listener had its own mutex, while I introduced sharing the mutex with the owner object. Sorry, seems I completely forgot about this - my fault. That said, I am not sure the SolarMutex is a good solution here. While I see Mathias' point that calling into SFX-code should be guarded by the SolarMutex, I tend to not introduce such a pest (and locking the SM *is* a pest, as it over time propagates to all components which use the component which does it) without a real need. My preferred solution would be to add correct lifetime handling for the listener instance, in that it is not re-used for another storage, but disposed when the document/storage is disposed, and re-created when needed. However, that's at your discretion. Base should be fine with any of the solutions, including a locked SolarMutex. Sorry for introducing this bug. If you think the one who introduced it should also fix it, then please feel free to re-assign the issue back to me - I will of course let you review the fix then :) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
