To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=89545
------- Additional comments from [EMAIL PROTECTED] Fri May 16 10:03:23 +0000
2008 -------
I found that vcl/aqua/source/gdi/salgdi.cxx revision 1.66.6.4 changed the
behavior. This revision disabled CJK heuristics, and you seemed to added
aMetrics.leading to mnDescent to get adequate line height. However, adding
leading to mnDescent doesn't seem to be a good idea for fonts like Hiragino.
So, how about adding half of aMetrics.leading to mnAscent and rest half to
mnDescent like this?
Index: salgdi.cxx
===================================================================
RCS file: /cvs/gsl/vcl/aqua/source/gdi/salgdi.cxx,v
retrieving revision 1.68.32.6
diff -u -r1.68.32.6 salgdi.cxx
--- salgdi.cxx 8 May 2008 16:13:47 -0000 1.68.32.6
+++ salgdi.cxx 16 May 2008 10:02:28 -0000
@@ -1411,8 +1411,8 @@
// convert quartz units to pixel units
// please see the comment in AquaSalGraphics::SetFont() for details
const double fPixelSize = (mfFontScale * mfFakeDPIScale * fPointSize);
- pMetric->mnAscent = static_cast<long>(+aMetrics.ascent * fPixelSize
+ 0.5);
- pMetric->mnDescent = static_cast<long>((-aMetrics.descent +
aMetrics.leading) * fPixelSize + 0.5);
+ pMetric->mnAscent = static_cast<long>((+aMetrics.ascent +
aMetrics.leading / 2) * fPixelSize + 0.5);
+ pMetric->mnDescent = static_cast<long>((-aMetrics.descent +
aMetrics.leading / 2) * fPixelSize + 0.5);
pMetric->mnIntLeading = 0;
pMetric->mnExtLeading = 0;
// ATSFontMetrics.avgAdvanceWidth is obsolete, so it is usually set to zero
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
