To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=29152





------- Additional comments from [EMAIL PROTECTED] Tue Jun 10 09:16:06 +0000 
2008 -------
I see the problem. The InteractionHandler is still not transported to UCB 
always.

The last patch part regarding docfile.cxx looks good, although I am not sure
that SfxMedium::GetInteractionHandler() will be accepted by all the compilers as
const, since it changes the member of the pImp pointer.

The  last patch part regarding fileaccess.cxx and ucbhelper.cxx does not help
since the xInteractionHandler reference wrapped with
::comphelper::StillReadWriteInteraction is empty, and thus can not show any
dialog. But even if is would be initialized with the default InteractionHandler,
it would be even worse hack than it was before. Before the interaction handler
was explicitly created only for webdav protocol, and now it would be created for
all the protocols. So from my point of view it is no acceptable solution.

The ucbhelper.cxx could be fixed easily by providing the InteractionHandler to
the help functions as an argument. The problem with fileaccess.cxx is more
difficult, the service implemented there does not allow to provide the
InteractionHandler at all so it should be reimplemented. As well as the
implementations that use the service. I am not sure that it is possible to reach
this for OOo3.0.

To reach the OOo3.0 deadline I would suggest to use SfxMedium as a buffer as it
was actually done before ( implicit ) for webdav protocol, since the protocol
did not allow to write directly. It is a pretty small change, in
SfxMedium::GetOutputStorage() the call GetTempFileNoCopy() should not be called
only for local files for now ( IsLocalFile() check instead of
SupportsActiveStreaming ). If this workaround will be used, please write me a
new bug to fix SfxMedium for the direct saving for the webdav account in future.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to