To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878
------- Additional comments from [EMAIL PROTECTED] Sat Jun 14 12:48:14 +0000 2008 ------- > I don't think mbDirectVisible could be set when isEnableVisible is False. > Because the window is invisible at this time. Invisible form should not be > set invisible or visible. Hmm - why? With your current code, consider the following scenario: - EnableVisible is set to FALSE - some instance calls "setVisible( sal_False )", which means "make this control invisible, no matter what" - now some other instance sets EnableVisible to TRUE => suddenly, the control will appear. This would most certainly be wrong, since the previous "setVisible( sal_False )" was meant unconditionally: "just hide it". Also, regarding your "Invisible form should not be set invisible or visible.": The control is *not* invisible in this scenario - it's just that it's disabled to become visible, this is what "EnableVisible = FALSE" means. So, my understanding would be - "EnableVisible" controls whether a control *can* be visible - mbDirectVisible, set by setVisible, controls whether the control is actually visible, in case EnableVisible would be TRUE at this time. > If we test the mbDirectVisible when isEnableVisible is set to True, its > behavior will be some against with the behavior set mbEnableVisible to > False. > mbEnableVisible -> False, form will be invisible, without think about > mbDirectVisible > mbEnableVisible -> True, form's behavior should similar with above, ignore > mbDirectVisible, set mbDirectVisible to True and show the form. Again, why? This would mean that EnableVisibile is not really used in the sense of "Enable", but in the sense of "do it": Whenever somebody changes EnableVisible to TRUE, then it *will* become visible, and when somebody changes it to FALSE, it will become invisible. This would actually mean we could have named it "Visible", because that's what it would be then. And we already said that a pure "Visible" property does not work in all scenarios - for instance in the scenario I described in the review. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
