To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=90426
------- Additional comments from [EMAIL PROTECTED] Fri Jun 27 13:06:56 +0000
2008 -------
@kendy:
- ULONG/sal_Size: The SvOutputStreamOpenLockBytes part of strmadpt.cxx is not
affected by this patch (it could be ehanced independently of this issue, to
reflect the apparent changes to underlying SvLockBytes).
- available(): Oops, "static_cast<sal_uInt32>(SAL_MAX_UINT32)" is indeed wrong,
it must read "static_cast<sal_uInt32>(SAL_MAX_INT32)" instead (and the following
two lines are also nonsense). Thanks for noting; fixed
DEV300m21-strmadpt-2.patch attached. ("static_cast<sal_Size>(SAL_MAX_INT32)"
would be misleading, and only by accident right, as this is about turning a
signed-but-nonnegative value of type sal_Int32 into an unsigned value (of
arbitrary unsigned type), and sal_uInt32 is by definition capable of holding any
nonegative value of type sal_Int32, while sal_Size is only by accident; also,
std::min has the disadvantage that you need to write down the type of
"aStat.nSize - m_nPosition", which is unknown in general.)
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
