To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=59064





------- Additional comments from [EMAIL PROTECTED] Mon Jul  7 09:08:34 +0000 
2008 -------
Regarding your third bullet item: There is a difference between loading a
document and pasting it via the clipboard. Your example documents looks fine if
you load them directly into OOo. There is only an issue if you paste them from
Firefox into OpenOffice.org. So there must be a difference between the source
code of the document itself, and the one that is pasted. I don't know what the
HTML that is pasted looks like, but my assumption is that body tags are missing.
However, the content of unknown elements in the body of the document are
displayed by OOo. That's not the issue.

Regarding your 2nd bullet item: I have created a test document which includes an
unknown element in the header, and my Firefox displayed it. I believe this
behavior was different in the past, because otherwise I wouldn't have
implemented this difficult logic that ignores the content of unknown elements in
the header, but displays them in the body. Anyway, it seems that it nowadays it
is safe to display the content of unknown elements in the header, too.

Actually, I do not like the big if (as you called it), too. But its only purpose
is to ignore the content of unknown elements in the header. If we do not want to
ignore the content of these elements in the future (and that appears to be
reasonable to me now), then the better way to achieve this is to remove this
"if", as well the "if" whose content is modified by your patch. Otherwise, we
have the situation that we first evaluate the "if" and set "aUnknownElement"
according to it, but later ignore the value of "aUnkownElement". This does not
make the code more robust and maintainable.

So, to summarize. It is okay for me display content of unknown elements in the
header, but we should do so by removing the logic that currently prevents that
rather than keeping this logic and adding some extra code.


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to