To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=88878


User fs changed the following:

                What    |Old value                 |New value
================================================================================
                      CC|'cd,dr,mt,npower'         |'cd,dr,fs,mt,npower'
--------------------------------------------------------------------------------
             Assigned to|fs                        |npower
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Wed Sep  3 19:34:19 +0000 
2008 -------
Noel, I'm glad to see you taking this feature. Do you mind if I assign it to 
you? :)

IIRC (I also didn't (re-)read all of the above :), the only major open issue was
the semantics of the EnableVisible property.

We initially agreed that it in fact is really an "enable the control to become
visible", where the actual visibility depends on calls to the XWindow's
setVisible. This is because there's a lot of scenarios (described above
somewhere) where a component decides to set a control window to in/visible,
*without* tampering with the model (which would affect *all* control windows
belonging to the model).

However, the latest version of the patch does not follow this semantics, instead
EnableVisible is effectively treated like "Visible" at the VCLXWindow. IMO, this
is wrong, and will lead to problems.


Note that when you work on this patch, you should use a milestone prior to
DEV300m30. In m30, CWS aw033 was integrated, which broke large parts of the form
control functionality. In particular, the visibility of form control windows is
not correct anymore. (Search for open issues submitted by fs and owned by aw to
get an idea. It will also find you some issues which describe interesting
scenarios to test together with this new visibility property, such as hiding a
section in which a control is anchored.)


Thinking about it .... something we never talked about is how to represent
"invisible" controls (i.e. control windows whose model has the EnableVisible
property set to false) in design mode. It might be desirable to somehow indicate
they're to be invisible in alive mode - perhaps by "shadowing" them in some way.
I suppose that the Drawing Layer's overlays nowadays should easily support this.
However, such a feature probably belongs into the "nice-to-have", not into the
"must-have" category. (Though I'm not completely sure, I would need to play with
the final feature to get a final opinion.)

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to