To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=93288
User fs changed the following:
What |Old value |New value
================================================================================
CC|'fs,pancapangrawit' |'fs,mav,pancapangrawit'
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Wed Sep 3 19:47:12 +0000
2008 -------
fs->mav: you were too generous in your fix: In revision 1.36.24.1 of
dbloader.cxx, consider line 175 ff:
if ( bStreamFromDescr && sURL.compareTo( ... ), 14 ) != COMPARE_EQUAL );
{
...
}
Note the superfluous semicolon at the end of the if-statement - it effectively
means that the code inside the brackets, which is intended to be executed only
if the if-statement evaluates to true, is executed unconditionally.
I suppose it's not worth fixing this for OOO300, since it "just" means that the
input-stream needs to be re-created when the document is actually loaded. But
please fix it on the DEV300 branch.
Also, another change which was not in the initial patch attached to this issue
is the closing of the input stream. While this is a Good Thing (TM), please note
that in DBA's code there's rarely such a thing as "catch( Exception& ) {}". This
almost always has to be
catch ( Exception& )
{
DBG_UNHANDLED_EXCEPTION();
}
, i.e. the error (and catching an exception here is an error) really should be
reported in a non-product build, so it can at least be noticed and investigated,
if it ever happens.
(Oh, and one thing I in fact overlooked in the review of the attached patch is
the minor thing that NamedValueCollection also has a ASCII version of "remove",
so there's no need to create the ::rtl::OUString when calling it :)
Sorry for coming up with those issues (which are not serious at all) that late.
I just needed to add your patch to a CWS of mine, and thus stumbled upon those
things ...
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
