To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483


User fme changed the following:

                What    |Old value                 |New value
================================================================================
             Assigned to|lijian                    |fme
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Wed Sep 10 07:31:22 +0000 
2008 -------
fme->lijian: Thank you for your patch. Please find my comments below:

[...] In fact, I think the perfect solution is to make the inserting of the OLE 
objects just like text frames/images even the cursor is in hidden paragraph.
But I think one solution is to avoid the calling of CalcAndSetScale( xObj ) 
and pClient->DoVerb( SVVERB_SHOW ) if the cursor is in hidden paragraph in 
function SwWrtShell::InsertObject in file wrtsh1.cxx. Maybe od could give help 
on this, right ? [...] 

Well, that's the crucial point. I also prefer the perfect solution. But as I
already on 2008-09-01, there's also an infinite loop in crsrsh.cxx in a current
version. So there's more obviously more left to consider than simply avoiding
the crash. Please switch your workspace to a more recent version and you'll see.
And that's the reason why I think we might be better of with the 'simple'
solution, since this issue actually only shows under some pretty rare 
circumstances.

Your patch works fine, I'll have a look if we should also disable some other
(possibly all) items in the text shell. Thank you for your good work.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to