To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96109 Issue #|96109 Summary|sw: dubious code Component|Word processor Version|DEV300m35 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|code Assigned to|ama Reported by|cmc
------- Additional comments from [EMAIL PROTECTED] Tue Nov 11 15:48:44 +0000 2008 ------- in sw/source/ui/uiview/viewport.cxx we have... if ( bRepeat && nCnt > 10 || (nCnt > 3 && bHAuto && bAuto && bAuto && bHAuto) ) i.e. (bHAuto && bAuto && bAuto && bHAuto) which doesn't make a lot of sense, perhaps there was intended to be a use of bVAuto in there, or maybe it just got duplicated accidentally and should simply be... if ( bRepeat && nCnt > 10 || (nCnt > 3 && bHAuto && bAuto) ) the second thing is that it's a little ambiguous if the operator precedence that will be used is truly intentional, i.e. that becomes... if ( (bRepeat && nCnt > 10) || (nCnt > 3 && bHAuto && bAuto) ) but there's a chance that the meaning might be if ( bRepeat && (nCnt > 10 || (nCnt > 3 && bHAuto && bAuto)) ) sticking some brackets around it to explicitly state the intent would be great --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
