To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96165
                 Issue #|96165
                 Summary|sd: ambiguous && ||
               Component|Drawing
                 Version|DEV300m35
                Platform|All
                     URL|
              OS/Version|Linux
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|PATCH
                Priority|P3
            Subcomponent|code
             Assigned to|graphicsneedsconfirm
             Reported by|cmc





------- Additional comments from [EMAIL PROTECTED] Wed Nov 12 16:52:05 +0000 
2008 -------
in source/filter/eppt/pptexanimations.cxx we have

if ( ( nPresetClass == (sal_uInt32)EffectPresetClass::ENTRANCE ) || (
nPresetClass == (sal_uInt32)EffectPresetClass::EXIT ) && ( nPresetId != 21 ) )

by operator precedence this expands to.

if (
    (nPresetClass == (sal_uInt32)EffectPresetClass::ENTRANCE) ||
    ((nPresetClass == (sal_uInt32)EffectPresetClass::EXIT) && (nPresetId != 21))
   )   

is that really what we meant, if so then attachment 1 makes this explicit.

or did we actually mean

if (
    (   
     (nPresetClass == (sal_uInt32)EffectPresetClass::ENTRANCE) ||
     (nPresetClass == (sal_uInt32)EffectPresetClass::EXIT)
    ) &&  
    (nPresetId != 21) 
   )   

which is what patch 2 would do

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to