To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96140
                 Issue #|96140
                 Summary|oox: ambiguous && ||
               Component|Spreadsheet
                 Version|DEV300m35
                Platform|All
                     URL|
              OS/Version|Linux
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|PATCH
                Priority|P3
            Subcomponent|open-import
             Assigned to|dr
             Reported by|cmc





------- Additional comments from [EMAIL PROTECTED] Wed Nov 12 10:36:41 +0000 
2008 -------
in oox/source/xls/worksheethelper.cxx
we have
if( rCellData.mxCell.is() && (rCellData.mnXfId >= 0) || (rCellData.mnNumFmtId >=
0) )
which by precedence is 
if( (rCellData.mxCell.is() && (rCellData.mnXfId >= 0)) || (rCellData.mnNumFmtId
>= 0) )

(as attachment 1 makes explicit)

but is that really what we want, superficially it looks like

if( rCellData.mxCell.is() && ((rCellData.mnXfId >= 0) || (rCellData.mnNumFmtId
>= 0) ))

might have been intended ? 

(as attachment 2 would change it to be)

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to